Thanks for that,
Going to get a new o-ring and a circlip to keep it in there for good, fortunately my basket is in good condition
EDIT: it appears that actually from having a short shifter in there for a while it has worn out the basket and stopped it holding as tightly, so I'm going to get a new one from partsouq
Going to get those new bits hopefully it will hold tight after that